Skip to content

Save message_key in Grape::Exceptions::Validation #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Save message_key in Grape::Exceptions::Validation #1210

wants to merge 1 commit into from

Conversation

Darksecond
Copy link

This way you can make better API errors, that have a stable message_key, alongside a translated message.

@dblock
Copy link
Member

dblock commented Nov 24, 2015

This needs tests and a CHANGELOG entry.

Also take a look at #1203, maybe we can do something similar?

@dblock
Copy link
Member

dblock commented Dec 8, 2015

Bump @Darksecond

@stjhimy stjhimy mentioned this pull request Dec 10, 2015
Closed
@dblock
Copy link
Member

dblock commented Dec 11, 2015

Closing in favor of #1227.

@dblock dblock closed this Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darksecond @dblock